EmaMaker
/
voxel-engine
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Misc fixes in preparation for multithreading refactor #10

Merged
EmaMaker merged 10 commits from multithread-refactor into main 2023-10-03 22:55:28 +02:00
Conversation 0 Commits 10 Files Changed 12
EmaMaker commented 2023-10-03 22:52:54 +02:00
Owner

I'm refactoring the whole multithread/onetbb logic to fix logic and design errors and terrible memory leaks. The end result is in branch fix-multithread.
I'm cherry-picking commits and manually applying fixes since fix-multithread is an untidy mess of squashed and improperly organized commits.
This PR is a mix of various bug fixes and codebase improvements that lay the ground to upcoming PRs

I'm refactoring the whole multithread/onetbb logic to fix logic and design errors and terrible memory leaks. The end result is in branch fix-multithread. I'm cherry-picking commits and manually applying fixes since fix-multithread is an untidy mess of squashed and improperly organized commits. This PR is a mix of various bug fixes and codebase improvements that lay the ground to upcoming PRs
EmaMaker added 9 commits 2023-10-03 22:53:03 +02:00
880c634be0 camera: set atomic position at startup 
this avoids the first few chunk update loops recognizing the camera as being positioned at (0,0,0), which in turns avoids wastefully generating chunks out of view at startup
ca043bac68 threads: allow for proper shutdown 
using `if` instead of `while` avoids the need to wait for the queue to empty to shutdown the thread
c6d00c4200 fix type mismatch in chunk index/coordinates 
typedef an appropriate chunk_index_t and chunk_intcoord_t
EmaMaker changed title from Misc fixes in preparation for threads refactor to Misc fixes in preparation for multithreading refactor 2023-10-03 22:53:18 +02:00
EmaMaker added 1 commit 2023-10-03 22:53:58 +02:00
EmaMaker merged commit 44edf3e53a into main 2023-10-03 22:55:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: EmaMaker/voxel-engine#10
There is no content yet.
Delete Branch "multithread-refactor"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?